Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8056 )
Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet ...................................................................... Patch Set 5: (2 comments) I'm close to a +1 on this. Only minor thoughts left for me. I just invited Tim to the review. http://gerrit.cloudera.org:8080/#/c/8056/5/tests/query_test/test_scanners_fuzz.py File tests/query_test/test_scanners_fuzz.py: http://gerrit.cloudera.org:8080/#/c/8056/5/tests/query_test/test_scanners_fuzz.py@103 PS5, Line 103: with no compression. Nit: I would emphasize that this has a new table. Something like: "into a new table with no compression" http://gerrit.cloudera.org:8080/#/c/8056/5/tests/query_test/test_scanners_fuzz.py@110 PS5, Line 110: for orig_tbl_name in tbl_list: : src_table_name = "parquet_uncomp_src_" + orig_tbl_name : dst_table_name = "parquet_uncomp_dst_" + orig_tbl_name Nit: I think I would prefer to have "dst_table_name" be "fuzz_table_name". Also, in other code, I think it would be good to be explicit about this being the fuzz_db and fuzz_table rather than dst_db and dst_table. -- To view, visit http://gerrit.cloudera.org:8080/8056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I760de7203a51cf82b16016fa8043cadc7c8325bc Gerrit-Change-Number: 8056 Gerrit-PatchSet: 5 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 02 Oct 2017 22:05:50 +0000 Gerrit-HasComments: Yes
