Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8056 )
Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/8056/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8056/6//COMMIT_MSG@12 PS6, Line 12: > Can you mention what testing you did? The fuzz tests are randomised we shou Done http://gerrit.cloudera.org:8080/#/c/8056/6/tests/query_test/test_scanners_fuzz.py File tests/query_test/test_scanners_fuzz.py: http://gerrit.cloudera.org:8080/#/c/8056/6/tests/query_test/test_scanners_fuzz.py@101 PS6, Line 101: """Parquet tables in default schema are compressed, so in order > It's weird that parquet/none means parquet/snappy. Unsure what the history Added a comment stating that parquet/none means default SNAPPY compression is set. http://gerrit.cloudera.org:8080/#/c/8056/6/tests/query_test/test_scanners_fuzz.py@116 PS6, Line 116: " select * from functional_parquet.{1}".format(fq_tbl_name, orig_tbl_name)) > Long lines > 90 chars here and just below. Fixed it. http://gerrit.cloudera.org:8080/#/c/8056/6/tests/query_test/test_scanners_fuzz.py@140 PS6, Line 140: self.execute_query("create table %s.%s like %s.%s" % (fuzz_db, fuzz_table, src_db, src_table)) > Long line Done -- To view, visit http://gerrit.cloudera.org:8080/8056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I760de7203a51cf82b16016fa8043cadc7c8325bc Gerrit-Change-Number: 8056 Gerrit-PatchSet: 6 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 03 Oct 2017 23:45:55 +0000 Gerrit-HasComments: Yes
