Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8212 )
Change subject: IMPALA-6016: Fix logging in TableLoadingMgr class ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8212/1/fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java File fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java: http://gerrit.cloudera.org:8080/#/c/8212/1/fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java@72 PS1, Line 72: LOG.info(String.format("Remaining items in queue: %s. Loads in progress: %s", > I think the "Remaining" part is now wrong because the size includes the tab Not totally sure I understand this. Do you mean the current table (represented by tableName_) would be included in tableLoadingDeque_.size() ? If thats what you meant, doesn't L288 remove it off the queue? Please correct me if you meant something else here. http://gerrit.cloudera.org:8080/#/c/8212/1/fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java@293 PS1, Line 293: return; > Can you also add a log message here indicating that the table is already be Done -- To view, visit http://gerrit.cloudera.org:8080/8212 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I925a6ba9a09be25df2759da5e6d85dfc8b981ce4 Gerrit-Change-Number: 8212 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Comment-Date: Thu, 05 Oct 2017 02:18:24 +0000 Gerrit-HasComments: Yes
