Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8212 )

Change subject: IMPALA-6016: Fix logging in TableLoadingMgr class
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8212/1/fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java
File fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java:

http://gerrit.cloudera.org:8080/#/c/8212/1/fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java@72
PS1, Line 72:         LOG.info(String.format("Remaining items in queue: %s. 
Loads in progress: %s",
> Not totally sure I understand this. Do you mean the current table (represen
Sorry, I got confused about the code flow. Current code lgtm.


http://gerrit.cloudera.org:8080/#/c/8212/2/fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java
File fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java:

http://gerrit.cloudera.org:8080/#/c/8212/2/fe/src/main/java/org/apache/impala/catalog/TableLoadingMgr.java@293
PS2, Line 293:       LOG.info("Another metadata load request already in 
progress for table: " +
Remove "Another"



--
To view, visit http://gerrit.cloudera.org:8080/8212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I925a6ba9a09be25df2759da5e6d85dfc8b981ce4
Gerrit-Change-Number: 8212
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Comment-Date: Thu, 05 Oct 2017 03:54:48 +0000
Gerrit-HasComments: Yes

Reply via email to