Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 )
Change subject: IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8226/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8226/1//COMMIT_MSG@10 PS1, Line 10: which returns multiple batches instead of one. that will cause us to still have to pin the entire stream in memory. Instead, I think the ask of the JIRA is the change the callers to use the GetNext() interface, so that they only need to keep a single batch in memory at a time, since I believe all callers are really just iterating through the stream anyway. -- To view, visit http://gerrit.cloudera.org:8080/8226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3831c38994da2b69775a9809ff01de5d23584414 Gerrit-Change-Number: 8226 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Fri, 06 Oct 2017 18:47:32 +0000 Gerrit-HasComments: Yes
