Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 )
Change subject: IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches ...................................................................... Patch Set 1: > Patch Set 1: > > > (1 comment) > > Correct, it will unpin/pin multiple times. But if the memory is available the > buffers will stay in memory even though it was unpinned (you'll want to take > a look through the buffer pool code starting with the header comments). If > the memory is not available, then we will read from disk but compare that to > today where we'd run out of memory and fail. It does mean, however, that rows > are "unflattened" multiple times. > > It would be good to sync up with Tim about this JIRA to ask his intention > when he returns on Monday. I believe the JIRA was filed a while back before > we did a big rework of these layers (I think the JIRA still makes sense, but > good to sync up). Thanks. I will abandon this patch for now. -- To view, visit http://gerrit.cloudera.org:8080/8226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3831c38994da2b69775a9809ff01de5d23584414 Gerrit-Change-Number: 8226 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Fri, 06 Oct 2017 21:56:40 +0000 Gerrit-HasComments: No
