Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 )
Change subject: IMPALA-5789: Add always_false flag in bloom filter ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/8170/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8170/3//COMMIT_MSG@13 PS3, Line 13: Testing > I assume you ran the existing runtime filter tests? Yes. Commit message is updated with the clarification. http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/common/global-flags.cc@129 PS3, Line 129: testing purposes. Effective in debug builds only."); > This is a little cluttered. I think its okay to just say "for testing purpo Done http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/exec/filter-context.h File be/src/exec/filter-context.h: http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/exec/filter-context.h@129 PS3, Line 129: CheckForAlwaysFalse( > I think this needs to be renamed for two reasons: Done http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/runtime/runtime-filter.inline.h File be/src/runtime/runtime-filter.inline.h: http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/runtime/runtime-filter.inline.h@53 PS3, Line 53: return bloom_filter_ != BloomFilter::ALWAYS_TRUE_FILTER && bloom_filter_->AlwaysFalse(); : } > single line? Done http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/util/bloom-filter.h File be/src/util/bloom-filter.h: http://gerrit.cloudera.org:8080/#/c/8170/3/be/src/util/bloom-filter.h@111 PS3, Line 111: hasn't had any elements inserted. > hasn't had any elements inserted Done http://gerrit.cloudera.org:8080/#/c/8170/3/tests/custom_cluster/test_always_false_filter.py File tests/custom_cluster/test_always_false_filter.py: http://gerrit.cloudera.org:8080/#/c/8170/3/tests/custom_cluster/test_always_false_filter.py@34 PS3, Line 34: f assert_file_rejected(result): : assert re.search("Files rejected: 8 \(8\)", resu > I think you can just add 'cursor' as a parameter to the 'test_' functions. Done. -- To view, visit http://gerrit.cloudera.org:8080/8170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If680240a3cd4583fc97c3192177d86d9567c4f8d Gerrit-Change-Number: 8170 Gerrit-PatchSet: 4 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 10 Oct 2017 22:47:39 +0000 Gerrit-HasComments: Yes
