Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 )
Change subject: IMPALA-5789: Add always_false flag in bloom filter ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/8170/7/tests/custom_cluster/test_always_false_filter.py File tests/custom_cluster/test_always_false_filter.py: http://gerrit.cloudera.org:8080/#/c/8170/7/tests/custom_cluster/test_always_false_filter.py@37 PS7, Line 37: query = """select STRAIGHT_JOIN * from alltypes inner join > Would be better to use the """ multi-line literals Done http://gerrit.cloudera.org:8080/#/c/8170/7/tests/query_test/test_runtime_filters.py File tests/query_test/test_runtime_filters.py: http://gerrit.cloudera.org:8080/#/c/8170/7/tests/query_test/test_runtime_filters.py@55 PS7, Line 55: " > nit: extra space. Maybe also use the """ multi-line literals Done -- To view, visit http://gerrit.cloudera.org:8080/8170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If680240a3cd4583fc97c3192177d86d9567c4f8d Gerrit-Change-Number: 8170 Gerrit-PatchSet: 8 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 19 Oct 2017 23:30:27 +0000 Gerrit-HasComments: Yes
