Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 )
Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src/service. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8305/1/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/8305/1/be/src/service/client-request-state.cc@a91 PS1, Line 91: What do you think about going a step further and replacing all callers of TimestampValue::LocalTime() with UnixMicros() or the like ? There doesn't seem to be many callers left after this patch. http://gerrit.cloudera.org:8080/#/c/8305/1/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/8305/1/be/src/service/impala-http-handler.cc@303 PS1, Line 303: int64_t duration_us = record.end_time_us - record.start_time_us; > that can be negative if settimeofday() occurred in the mean time. What shou That's true but that also seems to be a pre-existing bug. I agree that we should handle it though. -- To view, visit http://gerrit.cloudera.org:8080/8305 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I642a1d713597826bb7c15cd2ecb6638cb813a02c Gerrit-Change-Number: 8305 Gerrit-PatchSet: 1 Gerrit-Owner: Zoram Thanga <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Wed, 18 Oct 2017 19:22:28 +0000 Gerrit-HasComments: Yes
