Dan Hecht has posted comments on this change. (
http://gerrit.cloudera.org:8080/8305 )
Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.
......................................................................
Patch Set 4:
What about common-metrics.cc?
And then, I think we should move TimestampValue::{LocalTime(), UtcTime()} to
expr-test.cc so that it's not even part of the TimestampValue interface.
--
To view, visit http://gerrit.cloudera.org:8080/8305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I642a1d713597826bb7c15cd2ecb6638cb813a02c
Gerrit-Change-Number: 8305
Gerrit-PatchSet: 4
Gerrit-Owner: Zoram Thanga <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Zoram Thanga <[email protected]>
Gerrit-Comment-Date: Thu, 19 Oct 2017 19:57:10 +0000
Gerrit-HasComments: No
