Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 )
Change subject: IMPALA-5018: Error on decimal divide by and modulo zero ...................................................................... Patch Set 1: (1 comment) I need to look at the other decimal patches in more detail since there's more to digest This one seems simpler. Only question I had was about wording of the error message. http://gerrit.cloudera.org:8080/#/c/8344/1/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: http://gerrit.cloudera.org:8080/#/c/8344/1/be/src/exprs/decimal-operators-ir.cc@737 PS1, Line 737: Decimal division by or modulo zero I think the phrasing is potentially confusing, specifically the "or" makes it a little hard to parse. Not sure what others think. Maybe something like: "Divide by zero caused by decimal division or modulo". Or "Cannot divide decimal value by zero". -- To view, visit http://gerrit.cloudera.org:8080/8344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7a7131e657fcdd293ade78d62f851dac0f1e3eb Gerrit-Change-Number: 8344 Gerrit-PatchSet: 1 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Fri, 20 Oct 2017 00:27:40 +0000 Gerrit-HasComments: Yes
