Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344 )
Change subject: IMPALA-5018: Error on decimal modulo or divide by zero ...................................................................... Patch Set 2: (1 comment) In the JIRA, Greg made a comment about tying this to strict mode. Did we reach consensus on that with him? http://gerrit.cloudera.org:8080/#/c/8344/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/8344/2/be/src/exprs/expr-test.cc@1561 PS2, Line 1561: expected null, scaled_val, precision, scale for V1 : // expected null, scaled_val, precision, scale for V2 }} that needs updating -- To view, visit http://gerrit.cloudera.org:8080/8344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7a7131e657fcdd293ade78d62f851dac0f1e3eb Gerrit-Change-Number: 8344 Gerrit-PatchSet: 2 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Fri, 20 Oct 2017 22:37:14 +0000 Gerrit-HasComments: Yes
