Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 )
Change subject: IMPALA-6070: Parallel compute_table_stats.py ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8354/1/tests/util/compute_table_stats.py File tests/util/compute_table_stats.py: http://gerrit.cloudera.org:8080/#/c/8354/1/tests/util/compute_table_stats.py@37 PS1, Line 37: statement = "compute stats %s" % (db_table,) > Do these prints come out clean or all garbled due to the parallelism? They do. At first I thought I didn't care, but you're right, and I've fixed it. I switched to using python logging, which has its own logging to prevent interleaving. As a bonus, we get timestamps if we want to debug how long things take, and thread ids to make it obvious that there's parallelism. http://gerrit.cloudera.org:8080/#/c/8354/1/tests/util/compute_table_stats.py@119 PS1, Line 119: impala_client.connect() > please add newline to separate more cleanly Done -- To view, visit http://gerrit.cloudera.org:8080/8354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb080f2552b9dbe304ecadd6e52429214094237d Gerrit-Change-Number: 8354 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Oct 2017 17:29:15 +0000 Gerrit-HasComments: Yes
