David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8354 )
Change subject: IMPALA-6070: Parallel compute_table_stats.py ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/8354/2/tests/util/compute_table_stats.py File tests/util/compute_table_stats.py: http://gerrit.cloudera.org:8080/#/c/8354/2/tests/util/compute_table_stats.py@48 PS2, Line 48: ror=False, par > It's a closure. Doing it inline in the main block lets the closure access o Thanks for the clarification. http://gerrit.cloudera.org:8080/#/c/8354/2/tests/util/compute_table_stats.py@71 PS2, Line 71: end(pool.apply_async(compute_stats_table > Let's say all_tables = ["a", "b", "c"] and selected_tables = ["b", "c", "d" Thanks for the clarification. I actually missed that you do the same thing for dbs on L67. I wasn't considering the fact that selected_tables might contain a table that's not in all_tables, or that selected_dbs might contain a db that's not in all_dbs. So one last probably naive question. Does screening out values that don't exist in all_* represent a possible silent failure -- say, if someone invokes the script with --db_names followed by a misspelled value? -- To view, visit http://gerrit.cloudera.org:8080/8354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb080f2552b9dbe304ecadd6e52429214094237d Gerrit-Change-Number: 8354 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Mon, 23 Oct 2017 19:14:29 +0000 Gerrit-HasComments: Yes
