Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 )
Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/8267/11/be/src/util/dict-test.cc File be/src/util/dict-test.cc: http://gerrit.cloudera.org:8080/#/c/8267/11/be/src/util/dict-test.cc@234 PS11, Line 234: // Generate a dictionary with 9 values (requires 3 bits to encode). > I don't understand how 3 bits can encode 9 different values. Should these b You're right, I meant 4 bits. The below comment made the same mistake (I went through a few iterations of this test) -- To view, visit http://gerrit.cloudera.org:8080/8267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35de0cf80c86f501c4a39270afc8fb8111552ac6 Gerrit-Change-Number: 8267 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 23 Oct 2017 21:14:57 +0000 Gerrit-HasComments: Yes
