Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 )
Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/8267/12/be/src/util/dict-test.cc File be/src/util/dict-test.cc: http://gerrit.cloudera.org:8080/#/c/8267/12/be/src/util/dict-test.cc@255 PS12, Line 255: {1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, > What is the benefit of this test? Won't it stop when it tries to decode the I wanted to make sure that it tested error propagation in UnpackAndDecode32Values() as well as UnpackAndDecodeUpTo31Values(), i.e. this code path: https://gerrit.cloudera.org/#/c/8267/12/be/src/util/bit-packing.inline.h@124 -- To view, visit http://gerrit.cloudera.org:8080/8267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35de0cf80c86f501c4a39270afc8fb8111552ac6 Gerrit-Change-Number: 8267 Gerrit-PatchSet: 12 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 23 Oct 2017 21:52:53 +0000 Gerrit-HasComments: Yes
