Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8368
Change subject: IMPALA-2235: Fix current db when shell auto-reconnects ...................................................................... IMPALA-2235: Fix current db when shell auto-reconnects When precmd tested the connection it didn't validate that if we are using the previously selected DB. The _validate_database method is responsible for that, but it only appended the "use <db>" command to the cmdqueue (command queue of Cmd class). But, at this point we might already have commands in the command queue that will run before the "use <db>" command. Also, the command processed by precmd can entirely skip the cmdqueue, therefore it is not enough to insert the "use <db>" command to the front of cmdqueue. We need to issue the USE command with the onecmd() method to execute it immediately. I extended the _validate_database method with an "immediately" flag. If this is true, _validate_database will use the onecmd() method. Otherwise, it will append the USE command to the cmdqueue to maintain the previous behaviour. I added a new automated test suite named test_shell_interactive_reconnect.py to the "custom cluster" tests. It sets the default database, and after reconnection it checks if the shell set it again automatically. One test case checks if the shell set the default db after manually reconnecting to the impala daemon by issuing the CONNECT command. The other test case checks if the shell set the default db after automatic reconnection due to cluster restart. I needed to start/restart the cluster in these tests. That functionality was already implemented in class TestBreakpadBase, but I didn't want the new tests to depend on code from an other test suite, therefore I moved TestBreakpadBase class to tests/common/cluster_controller.py and renamed it to ClusterController. I also needed to backup the impala shell history file because I didn't want to pollute it by the test cases (just like the way it is done in tests/shell/test_shell_interactive.py). I created utility functions for this in tests/shell/util.py and now test_shell_interactive.py and the newly created test suite are using these utility functions. Change-Id: I40dfa00ba0314d356fe8617446f516505c925e5e --- M shell/impala_shell.py A tests/common/cluster_controller.py M tests/custom_cluster/test_breakpad.py A tests/custom_cluster/test_shell_interactive_reconnect.py M tests/shell/test_shell_interactive.py M tests/shell/util.py 6 files changed, 243 insertions(+), 121 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/8368/2 -- To view, visit http://gerrit.cloudera.org:8080/8368 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I40dfa00ba0314d356fe8617446f516505c925e5e Gerrit-Change-Number: 8368 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
