Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8368 )
Change subject: IMPALA-2235: Fix current db when shell auto-reconnects ...................................................................... Patch Set 2: (5 comments) Thanks for doing this refactoring, I had some questions about whether we could improve it further, but I think the direction looks good. http://gerrit.cloudera.org:8080/#/c/8368/2/tests/common/cluster_controller.py File tests/common/cluster_controller.py: http://gerrit.cloudera.org:8080/#/c/8368/2/tests/common/cluster_controller.py@33 PS2, Line 33: class ClusterController(CustomClusterTestSuite): Woh, nice. http://gerrit.cloudera.org:8080/#/c/8368/2/tests/common/cluster_controller.py@34 PS2, Line 34: breakpad Comment needs update. I guess now it's used for all custom cluster tests that kill processes and restart the cluster? http://gerrit.cloudera.org:8080/#/c/8368/2/tests/common/cluster_controller.py@42 PS2, Line 42: self.tmp_dir = tempfile.mkdtemp() I'm thinking about whether this is factored in the best way and whether the additional layer of inheritance is needed. I think a lot of the below utility functions for starting the cluster and killing processes could be moved into CustomClusterTestSuite. Other aspects seem specific to the breakpad tests - disabling core dumps, the temporary directory manipulation. Maybe it makes sense to have those in a Breakpad test base class. What do you think? http://gerrit.cloudera.org:8080/#/c/8368/2/tests/common/cluster_controller.py@85 PS2, Line 85: def kill_processes(self, processes, signal): kill_processes() and wait_for_all_processes_dead() I think could just be standalone utility functions - they aren't specific to cluster tests. http://gerrit.cloudera.org:8080/#/c/8368/2/tests/shell/util.py File tests/shell/util.py: http://gerrit.cloudera.org:8080/#/c/8368/2/tests/shell/util.py@115 PS2, Line 115: move_history maybe move_shell_history()/restore_shell_history()? It's more verbose but I think is easier to understand at the callsites. -- To view, visit http://gerrit.cloudera.org:8080/8368 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40dfa00ba0314d356fe8617446f516505c925e5e Gerrit-Change-Number: 8368 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 26 Oct 2017 17:58:15 +0000 Gerrit-HasComments: Yes
