Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8366
to look at the new patch set (#3).
Change subject: IMPALA-1291: Parquet read fails if io buffer size is less than
the footer size
......................................................................
IMPALA-1291: Parquet read fails if io buffer size is less than the footer size
This commit introduces the compile-time constant READ_SIZE_MIN_VALUE
in the newly created common/global-flags.h
A static_assert checks if READ_SIZE_MIN_VALUE is greater than or equal to
HdfsParquetScanner::FOOTER_SIZE.
Also, moved the definition of read_size flag to global-flags.cc,
and declared it in global-flags.h.
Runtime checks test if read_size is greater than or eaqual to
READ_SIZE_MIN_VALUE. If not, the process is terminated.
Change-Id: Ib7364147e7daf5380f11368871f8479646b448da
---
M be/src/common/global-flags.cc
A be/src/common/global-flags.h
M be/src/common/init.cc
M be/src/exec/hdfs-parquet-scanner.h
M be/src/runtime/disk-io-mgr.cc
M be/src/util/backend-gflag-util.cc
6 files changed, 57 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/8366/3
--
To view, visit http://gerrit.cloudera.org:8080/8366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib7364147e7daf5380f11368871f8479646b448da
Gerrit-Change-Number: 8366
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
