Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8366 )
Change subject: IMPALA-1291: Parquet read fails if io buffer size is less than the footer size ...................................................................... IMPALA-1291: Parquet read fails if io buffer size is less than the footer size This commit introduces the compile-time constant READ_SIZE_MIN_VALUE in the newly created common/global-flags.h A static_assert checks if READ_SIZE_MIN_VALUE is greater than or equal to HdfsParquetScanner::FOOTER_SIZE. Also, moved the definition of read_size flag to global-flags.cc, and declared it in global-flags.h. Runtime checks test if read_size is greater than or eaqual to READ_SIZE_MIN_VALUE. If not, the process is terminated. Change-Id: Ib7364147e7daf5380f11368871f8479646b448da Reviewed-on: http://gerrit.cloudera.org:8080/8366 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/common/global-flags.cc A be/src/common/global-flags.h M be/src/common/init.cc M be/src/exec/hdfs-parquet-scanner.h M be/src/runtime/disk-io-mgr.cc M be/src/util/backend-gflag-util.cc 6 files changed, 57 insertions(+), 9 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib7364147e7daf5380f11368871f8479646b448da Gerrit-Change-Number: 8366 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong <[email protected]>
