Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8311 )
Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8311/2/be/src/exprs/udf-builtins-ir.cc File be/src/exprs/udf-builtins-ir.cc: http://gerrit.cloudera.org:8080/#/c/8311/2/be/src/exprs/udf-builtins-ir.cc@120 PS2, Line 120: return time.fractional_seconds() + time.seconds() * 1000 * 1000 * 1000; > Use NANOS_PER_SEC Done http://gerrit.cloudera.org:8080/#/c/8311/2/be/src/exprs/udf-builtins-ir.cc@125 PS2, Line 125: return ExtractNanosecond(time) / 1000; > Instead of dividing the result of another function, these should be impleme Done http://gerrit.cloudera.org:8080/#/c/8311/2/be/src/exprs/udf-builtins-ir.cc@130 PS2, Line 130: return ExtractMicrosecond(time) / 1000; > same comment applies Done -- To view, visit http://gerrit.cloudera.org:8080/8311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If23ea310ddcc5c1c806b2b1ac24d24a4bd6aa4d9 Gerrit-Change-Number: 8311 Gerrit-PatchSet: 2 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Mon, 30 Oct 2017 12:03:38 +0000 Gerrit-HasComments: Yes
