Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8311 )
Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC ...................................................................... Patch Set 4: (3 comments) Let's figure out how to address MILLISECONDS in the JIRA. We also should figure out what to do about rounding vs. truncation when converting to less precise units. http://gerrit.cloudera.org:8080/#/c/8311/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/8311/4/be/src/exprs/expr-test.cc@6037 PS4, Line 6037: TYPE_BIGINT, 28123); This is a compatibility breaking change; we need to document the issue. http://gerrit.cloudera.org:8080/#/c/8311/4/be/src/exprs/udf-builtins-ir.cc File be/src/exprs/udf-builtins-ir.cc: http://gerrit.cloudera.org:8080/#/c/8311/4/be/src/exprs/udf-builtins-ir.cc@a193 PS4, Line 193: This breaks compatibility; let's discuss what the most appropriate resolution is. http://gerrit.cloudera.org:8080/#/c/8311/4/be/src/exprs/udf-builtins-ir.cc@134 PS4, Line 134: return time.fractional_seconds() / NANOS_PER_MICRO / MICROS_PER_MILLI + time.seconds() * MILLIS_PER_SEC; Too confusing - please use / (NANOS_PER_MICRO * MICROS_PER_MILLI) -- To view, visit http://gerrit.cloudera.org:8080/8311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If23ea310ddcc5c1c806b2b1ac24d24a4bd6aa4d9 Gerrit-Change-Number: 8311 Gerrit-PatchSet: 4 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Tue, 31 Oct 2017 00:19:57 +0000 Gerrit-HasComments: Yes
