Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8411 )
Change subject: IMPALA-6124: Fix alter table ddl updates and test ...................................................................... Patch Set 3: Code-Review+1 (1 comment) The patch looks good to me, but I'm still curious how it worked before. Tried digging into the HMS code to see how the ddlTime is updated, but no clues. http://gerrit.cloudera.org:8080/#/c/8411/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/8411/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2769 PS3, Line 2769: catalog_.updateLastDdlTime( : new TTableName(msTbl.getDbName(), msTbl.getTableName()), lastDdlTime); Unrelated to this test failure, any idea why we do this if the alter fails? -- To view, visit http://gerrit.cloudera.org:8080/8411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3126252e7709304d3e1fa4bb06a0b847180bd6cf Gerrit-Change-Number: 8411 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Mon, 30 Oct 2017 19:02:14 +0000 Gerrit-HasComments: Yes
