Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8411 )
Change subject: IMPALA-6124: Fix alter table ddl updates and test ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Lgtm. Bharath, please do the +2 http://gerrit.cloudera.org:8080/#/c/8411/4/tests/metadata/test_last_ddl_time_update.py File tests/metadata/test_last_ddl_time_update.py: http://gerrit.cloudera.org:8080/#/c/8411/4/tests/metadata/test_last_ddl_time_update.py@25 PS4, Line 25: class TestLastDdlTimeUpdate(ImpalaTestSuite): Does this test still make sense? There's no code on our side that modifies the lastDdlTime -- To view, visit http://gerrit.cloudera.org:8080/8411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3126252e7709304d3e1fa4bb06a0b847180bd6cf Gerrit-Change-Number: 8411 Gerrit-PatchSet: 6 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Mon, 30 Oct 2017 23:42:11 +0000 Gerrit-HasComments: Yes
