Hello Greg Rahn, Matthew Mulder, Michael Brown, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8372 to look at the new patch set (#5). Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE ...................................................................... IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE The .test files in this commit are ones held out from IMPALA-5376 because of observed anomalies with returned decimal precision that I previously controlled with TRUNCATE(). This ticket was filed after team members expressed a preference not to use TRUNCATE() and to use actual results generated within numerical range of expected, unless the results could not be controlled otherwise. Rounds of testing for this commit show that the earlier anomalies no longer occur, clearing the way for their inclusion in our TPC-DS suite. It has been observed that these tests tend to fail with the DECIMAL_V2 option set (unless the test does so explicitly). Testing: The gerrit_verify_dryrun_external (build #24) job passes with this change. The fix (rebased hereon) to IMPALA-6106 (finally) cleared up a source of flapping for these tests. Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a --- A testdata/workloads/tpcds/queries/tpcds-q26.test A testdata/workloads/tpcds/queries/tpcds-q28.test M testdata/workloads/tpcds/queries/tpcds-q39-1.test M testdata/workloads/tpcds/queries/tpcds-q39-2.test A testdata/workloads/tpcds/queries/tpcds-q47.test A testdata/workloads/tpcds/queries/tpcds-q57.test A testdata/workloads/tpcds/queries/tpcds-q59.test M testdata/workloads/tpcds/queries/tpcds-q61.test A testdata/workloads/tpcds/queries/tpcds-q63.test M testdata/workloads/tpcds/queries/tpcds-q77a.test M testdata/workloads/tpcds/queries/tpcds-q78.test M testdata/workloads/tpcds/queries/tpcds-q86a.test M tests/query_test/test_tpcds_queries.py 13 files changed, 849 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/8372/5 -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wood <tw...@cloudera.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: Matthew Mulder <mmul...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>