Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 )
Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q26.test File testdata/workloads/tpcds/queries/tpcds-q26.test: http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q26.test@5 PS5, Line 5: 78.33333333333333 > The TPC-DS spec section 7.5.3.d says "For results from AVG aggregates, the Ack http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q39-1.test File testdata/workloads/tpcds/queries/tpcds-q39-1.test: http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q39-1.test@4 PS5, Line 4: -- ADD ROUND()s TO 4th, 5th, 9th, 10th COLUMNS, USE ACTUAL RESULT AS EXPECTED RESULT. > It looks like this is okay per the TPC-DS standard section 4.2.3.4.f.6: Exp Ack -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wood <tw...@cloudera.com> Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com> Gerrit-Reviewer: Matthew Mulder <mmul...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Wood <tw...@cloudera.com> Gerrit-Comment-Date: Mon, 13 Nov 2017 23:32:39 +0000 Gerrit-HasComments: Yes