Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm ...................................................................... Patch Set 3: (1 comment) I started looking through the first few files and it looks good to me so far. Maybe Bikram can continue the review though when he has time. http://gerrit.cloudera.org:8080/#/c/8489/3/be/src/codegen/codegen-anyval.cc File be/src/codegen/codegen-anyval.cc: http://gerrit.cloudera.org:8080/#/c/8489/3/be/src/codegen/codegen-anyval.cc@479 PS3, Line 479: llvm::cast search-and-replace gone wrong -- To view, visit http://gerrit.cloudera.org:8080/8489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7098baff5f746bcc2965583ca99f6188997b733a Gerrit-Change-Number: 8489 Gerrit-PatchSet: 3 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 08 Nov 2017 18:52:35 +0000 Gerrit-HasComments: Yes
