Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm ...................................................................... Patch Set 4: (2 comments) @Tim and Bikram, both of you wants rollback the changes for only be/src/codegen due to llvm's symbol change in the future. Do I proceed it? Or do you need further discussion? http://gerrit.cloudera.org:8080/#/c/8489/3/be/src/codegen/codegen-anyval.cc File be/src/codegen/codegen-anyval.cc: http://gerrit.cloudera.org:8080/#/c/8489/3/be/src/codegen/codegen-anyval.cc@479 PS3, Line 479: casts it b > search-and-replace gone wrong Fixed unintentional changes http://gerrit.cloudera.org:8080/#/c/8489/3/be/src/codegen/instruction-counter.cc File be/src/codegen/instruction-counter.cc: http://gerrit.cloudera.org:8080/#/c/8489/3/be/src/codegen/instruction-counter.cc@28 PS3, Line 28: const char* InstructionCounter::TOTAL_INSTS = "Total Instructions"; > This was probably not intentional? Fixed unintentional changes -- To view, visit http://gerrit.cloudera.org:8080/8489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7098baff5f746bcc2965583ca99f6188997b733a Gerrit-Change-Number: 8489 Gerrit-PatchSet: 4 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 09 Nov 2017 02:15:00 +0000 Gerrit-HasComments: Yes
