Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8513 )
Change subject: IMPALA-6160: Allow multiple statements in a Query object. ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/8513/4/tests/performance/query_executor.py File tests/performance/query_executor.py: http://gerrit.cloudera.org:8080/#/c/8513/4/tests/performance/query_executor.py@45 PS4, Line 45: DDL/DML > nit: CRUD Ack http://gerrit.cloudera.org:8080/#/c/8513/4/tests/performance/query_executor.py@190 PS4, Line 190: query (Query) > nit: can you please pluralize query everywhere it can be multiple queries, This "query" is not a string containing a batch of SQL statements, it's our Query object in Python. The multiple-ness is abstracted away, and only concerns the execute() function below. I'll change the synopsis to make that clear, but other users of QueryExecutor understand .query to be an object. http://gerrit.cloudera.org:8080/#/c/8513/4/tests/performance/query_executor.py@200 PS4, Line 200: query (Query): SQL query to be executed Will explain object identity here; this actually bit me when I treated it as a string! http://gerrit.cloudera.org:8080/#/c/8513/4/tests/performance/query_executor.py@230 PS4, Line 230: (generally, DDL and DML statements) > nit: please remove Ack -- To view, visit http://gerrit.cloudera.org:8080/8513 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac86af181b7c42655f21d2c1efd4652dd35d9297 Gerrit-Change-Number: 8513 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wood <tw...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Matthew Mulder <mmul...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Tim Wood <tw...@cloudera.com> Gerrit-Comment-Date: Tue, 14 Nov 2017 18:55:28 +0000 Gerrit-HasComments: Yes
