Tim Wood has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8513 )

Change subject: IMPALA-6160: Allow multiple statements in a Query object.
......................................................................


Patch Set 5:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/8513/5/tests/performance/query.py
File tests/performance/query.py:

http://gerrit.cloudera.org:8080/#/c/8513/5/tests/performance/query.py@26
PS5, Line 26:     query_str (str): SQL query string; contains 1 or more 
;-delimited SQL statements.
Key context.


http://gerrit.cloudera.org:8080/#/c/8513/4/tests/performance/query_executor.py
File tests/performance/query_executor.py:

http://gerrit.cloudera.org:8080/#/c/8513/4/tests/performance/query_executor.py@45
PS4, Line 45: CRUD st
> Ack
Done


http://gerrit.cloudera.org:8080/#/c/8513/4/tests/performance/query_executor.py@200
PS4, Line 200:     query (Query): Container holding 1 or more ;-delimited SQL 
statements to be executed
> Will explain object identity here; this actually bit me when I treated it a
Done


http://gerrit.cloudera.org:8080/#/c/8513/4/tests/performance/query_executor.py@230
PS4, Line 230: first so timing does not include th
> Ack
Done



--
To view, visit http://gerrit.cloudera.org:8080/8513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac86af181b7c42655f21d2c1efd4652dd35d9297
Gerrit-Change-Number: 8513
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wood <tw...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org>
Gerrit-Reviewer: Matthew Mulder <mmul...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Nov 2017 19:24:05 +0000
Gerrit-HasComments: Yes

Reply via email to