Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 )
Change subject: IMPALA-5624: ProcessStateInfo::ReadProcFileDescriptorInfo() should not fork a process ...................................................................... Patch Set 2: Based on my reading of "man readdir", it's not threadsafe. I think the only usage here is if a user hits "http://impalad:.../"; to see the web UI. It's possible that there's a lock somewhere preventing concurrent use, but given that this is already reasonably expensive, I'd recommend using the reentrant readdir_r instead. I looked around, and it looks like C++17 and boost have filesystem abstractions, but I think readdir() is simple enough. -- To view, visit http://gerrit.cloudera.org:8080/8546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibffae8069a62e100abbfa7d558b49040b095ddc0 Gerrit-Change-Number: 8546 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 14 Nov 2017 19:09:00 +0000 Gerrit-HasComments: No
