Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 )
Change subject: IMPALA-5624: ProcessStateInfo::ReadProcFileDescriptorInfo() should not fork a process ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/8546/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8546/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-5624: ProcessStateInfo::ReadProcFileDescriptorInfo() should not fork a process Please describe in this line what the change does, not what it should do, i.e. "prevent fork". http://gerrit.cloudera.org:8080/#/c/8546/2//COMMIT_MSG@11 PS2, Line 11: posix nit: Posix is a name and should be capitalized. http://gerrit.cloudera.org:8080/#/c/8546/2//COMMIT_MSG@18 PS2, Line 18: "expected value" in advance, and the number of file desciptors can change anytime. Couldn't we test that a reasonable minimum number of file descriptors is returned, e.g. >0? http://gerrit.cloudera.org:8080/#/c/8546/2/be/src/util/process-state-info.h File be/src/util/process-state-info.h: http://gerrit.cloudera.org:8080/#/c/8546/2/be/src/util/process-state-info.h@99 PS2, Line 99: /// Number of file descriptors. Please clarify what kinds of file descriptors this counts. -- To view, visit http://gerrit.cloudera.org:8080/8546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibffae8069a62e100abbfa7d558b49040b095ddc0 Gerrit-Change-Number: 8546 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 14 Nov 2017 19:09:20 +0000 Gerrit-HasComments: Yes
