Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm ...................................................................... Patch Set 5: (2 comments) I had one nit but just fixed it myself since I don't think it's worth doing another iteration to fix. http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/codegen/codegen-callgraph.cc File be/src/codegen/codegen-callgraph.cc: http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/codegen/codegen-callgraph.cc@41 PS4, Line 41: for (llvm::Use& u: val->uses()) > I think we usually stick to using no space between ":" like IN the backend code, clang-format likes to put spaces on both sides, so that's what we've standardised on. The frontend code only has a trailing space. It doesn't really matter much though. http://gerrit.cloudera.org:8080/#/c/8489/5/be/src/exprs/scalar-expr.cc File be/src/exprs/scalar-expr.cc: http://gerrit.cloudera.org:8080/#/c/8489/5/be/src/exprs/scalar-expr.cc@260 PS5, Line 260: // Compute the alignment of this value. Values should be self-aligned for This formatting is weird - the old formatting was better. -- To view, visit http://gerrit.cloudera.org:8080/8489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7098baff5f746bcc2965583ca99f6188997b733a Gerrit-Change-Number: 8489 Gerrit-PatchSet: 5 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 15 Nov 2017 18:23:39 +0000 Gerrit-HasComments: Yes
