jt2594838 commented on a change in pull request #738: [IOTDB-396] New query clause: disable align URL: https://github.com/apache/incubator-iotdb/pull/738#discussion_r366230138
########## File path: jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBNonAlignQueryResultSet.java ########## @@ -0,0 +1,1289 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.jdbc; + +import org.apache.iotdb.rpc.IoTDBRPCException; +import org.apache.iotdb.rpc.RpcUtils; +import org.apache.iotdb.service.rpc.thrift.*; +import org.apache.iotdb.tsfile.exception.write.UnSupportedDataTypeException; +import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType; +import org.apache.iotdb.tsfile.utils.BytesUtils; +import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils; +import org.apache.thrift.TException; + +import java.io.InputStream; +import java.io.Reader; +import java.math.BigDecimal; +import java.math.MathContext; +import java.net.URL; +import java.nio.ByteBuffer; +import java.sql.Date; +import java.sql.*; +import java.util.*; + +public class IoTDBNonAlignQueryResultSet implements ResultSet { + + private static final String TIMESTAMP_STR = "Time"; + private static final int TIMESTAMP_STR_LENGTH = 4; + private static final int START_INDEX = 2; + private static final String VALUE_IS_NULL = "The value got by %s (column name) is NULL."; + private static final String EMPTY_STR = ""; + private Statement statement = null; + private String sql; + private SQLWarning warningChain = null; + private boolean isClosed = false; + private TSIService.Iface client = null; + private List<String> columnInfoList; // no deduplication + private List<String> columnTypeList; // no deduplication + private Map<String, Integer> columnInfoMap; // used because the server returns deduplicated columns + private List<String> columnTypeDeduplicatedList; // deduplicated from columnTypeList + private int fetchSize; + private boolean emptyResultSet = false; + + private TSQueryNonAlignDataSet tsQueryNonAlignDataSet = null; + private byte[][] times; // used for disable align + private byte[][] values; // used to cache the current row record value + + private long sessionId; + private long queryId; + private boolean ignoreTimeStamp = false; + + public IoTDBNonAlignQueryResultSet() { + // do nothing + } + + // for disable align clause + public IoTDBNonAlignQueryResultSet(Statement statement, List<String> columnNameList, + List<String> columnTypeList, boolean ignoreTimeStamp, TSIService.Iface client, + String sql, long queryId, long sessionId, TSQueryNonAlignDataSet dataset) + throws SQLException { + this.statement = statement; + this.fetchSize = statement.getFetchSize(); + this.columnTypeList = columnTypeList; + + times = new byte[columnNameList.size()][Long.BYTES]; + values = new byte[columnNameList.size()][]; + + this.columnInfoList = new ArrayList<>(); + // deduplicate and map + this.columnInfoMap = new HashMap<>(); + this.columnInfoMap.put(TIMESTAMP_STR, 1); + this.columnTypeDeduplicatedList = new ArrayList<>(); + int index = START_INDEX; + for (int i = 0; i < columnNameList.size(); i++) { + String name = columnNameList.get(i); + columnInfoList.add(TIMESTAMP_STR + name); + columnInfoList.add(name); + if (!columnInfoMap.containsKey(name)) { + columnInfoMap.put(name, index++); + columnTypeDeduplicatedList.add(columnTypeList.get(i)); + } + } + + this.ignoreTimeStamp = ignoreTimeStamp; + this.client = client; + this.sql = sql; + this.queryId = queryId; + this.tsQueryNonAlignDataSet = dataset; + this.sessionId = sessionId; + } + + @Override + public boolean isWrapperFor(Class<?> iface) throws SQLException { + throw new SQLException(Constant.METHOD_NOT_SUPPORTED); + } + + @Override + public <T> T unwrap(Class<T> iface) throws SQLException { + throw new SQLException(Constant.METHOD_NOT_SUPPORTED); + } + + @Override + public boolean absolute(int arg0) throws SQLException { + throw new SQLException(Constant.METHOD_NOT_SUPPORTED); + } + + @Override + public void afterLast() throws SQLException { + throw new SQLException(Constant.METHOD_NOT_SUPPORTED); + } + + @Override + public void beforeFirst() throws SQLException { + throw new SQLException(Constant.METHOD_NOT_SUPPORTED); + } + + @Override + public void cancelRowUpdates() throws SQLException { + throw new SQLException(Constant.METHOD_NOT_SUPPORTED); + } + + @Override + public void clearWarnings() throws SQLException { + throw new SQLException(Constant.METHOD_NOT_SUPPORTED); + } + + @Override + public void close() throws SQLException { + if (isClosed) { + return; + } + if (client != null) { + try { + TSCloseOperationReq closeReq = new TSCloseOperationReq(sessionId); + closeReq.setQueryId(queryId); + TSStatus closeResp = client.closeOperation(closeReq); + RpcUtils.verifySuccess(closeResp); + } catch (IoTDBRPCException e) { + throw new SQLException("Error occurs for close opeation in server side becasuse " + e); + } catch (TException e) { + throw new SQLException( + "Error occurs when connecting to server for close operation, becasue: " + e); + } + } + client = null; + isClosed = true; + } + + + @Override + public void deleteRow() throws SQLException { + throw new SQLException(Constant.METHOD_NOT_SUPPORTED); + } + + @Override + public int findColumn(String columnName) { + return columnInfoMap.get(columnName); + } + + @Override + public boolean first() throws SQLException { + throw new SQLException(Constant.METHOD_NOT_SUPPORTED); + } Review comment: These methods are duplicated with the aligned one, better to extract them into a base class like "IoTDBResultSet". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
