SteveYurongSu commented on a change in pull request #2436:
URL: https://github.com/apache/iotdb/pull/2436#discussion_r553092873
##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -653,9 +528,10 @@ public TSExecuteStatementResp
executeRawDataQuery(TSRawDataQueryReq req) {
*/
@SuppressWarnings("squid:S3776") // Suppress high Cognitive Complexity
warning
private TSExecuteStatementResp internalExecuteQueryStatement(String
statement,
- long statementId, PhysicalPlan plan, int fetchSize, String username)
throws IOException {
+ long statementId, PhysicalPlan plan, int fetchSize, String username)
+ throws QueryProcessException, SQLException, StorageEngineException,
QueryFilterOptimizationException, MetadataException, IOException,
InterruptedException, TException, AuthException {
Review comment:
First, I think we should try to catch errors in the outermost call.
In addition, the error handling process of internalExecuteQueryStatement is
roughly the same as that of its caller, and we should not let the similar error
handling process be executed twice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
