SteveYurongSu commented on a change in pull request #2436:
URL: https://github.com/apache/iotdb/pull/2436#discussion_r553093447
##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -1839,12 +1588,46 @@ private long generateQueryId(boolean isDataQuery, int
fetchSize, int deduplicate
return SchemaUtils.getSeriesTypesByPaths(paths, aggregations);
}
-
protected TSDataType getSeriesTypeByPath(PartialPath path) throws
MetadataException {
return SchemaUtils.getSeriesTypeByPath(path);
}
- public static int getDefaultFetchSize() {
- return DEFAULT_FETCH_SIZE;
+ private TSStatus onException(Exception e, String operation) {
+ TSStatus status = tryCatchQueryException(e);
+ return status != null ? status : onNPEOrUnexpectedException(e, operation,
+ TSStatusCode.INTERNAL_SERVER_ERROR);
+ }
+
+ private TSStatus tryCatchQueryException(Exception e) {
Review comment:
I think the name tryCatchQueryException is better, because errors that
flow through the tryCatchQueryException method may not be caught.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
