LebronAl commented on a change in pull request #4571:
URL: https://github.com/apache/iotdb/pull/4571#discussion_r769400671
##########
File path:
cluster/src/main/java/org/apache/iotdb/cluster/query/reader/ClusterReaderFactory.java
##########
@@ -897,11 +897,14 @@ private GroupByExecutor getRemoteGroupByExecutor(
logger.debug("{}: no data for {} from {}",
metaGroupMember.getName(), path, node);
return new EmptyReader();
}
- } catch (TException | IOException e) {
- logger.error("{}: Cannot query {} from {}", metaGroupMember.getName(),
path, node, e);
+ } catch (TException e) {
+ logger.error(metaGroupMember.getName() + ": Cannot query " + path + "
from " + node, e);
+ throw new StorageEngineException(e.getMessage());
Review comment:
any reasons ?
##########
File path:
cluster/src/main/java/org/apache/iotdb/cluster/query/aggregate/ClusterAggregator.java
##########
@@ -244,12 +244,16 @@ public ClusterAggregator(MetaGroupMember metaGroupMember)
{
results);
return results;
}
- } catch (TException | IOException e) {
+ } catch (TException e) {
+ logger.error(
+ metaGroupMember.getName() + " query aggregation error " + path + "
from " + node, e);
+ throw new StorageEngineException(e.getMessage());
Review comment:
any reasons ?
##########
File path:
integration/src/test/java/org/apache/iotdb/db/integration/IoTDBTtlIT.java
##########
@@ -39,7 +39,7 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
-@Category({LocalStandaloneTest.class, ClusterTest.class})
+@Category({LocalStandaloneTest.class})
Review comment:
why delete ClusterTest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
