ericpai commented on a change in pull request #4571:
URL: https://github.com/apache/iotdb/pull/4571#discussion_r769411380
##########
File path:
cluster/src/main/java/org/apache/iotdb/cluster/query/aggregate/ClusterAggregator.java
##########
@@ -244,12 +244,16 @@ public ClusterAggregator(MetaGroupMember metaGroupMember)
{
results);
return results;
}
- } catch (TException | IOException e) {
+ } catch (TException e) {
+ logger.error(
+ metaGroupMember.getName() + " query aggregation error " + path + "
from " + node, e);
+ throw new StorageEngineException(e.getMessage());
Review comment:
In my opinion, the retrying to other nodes only happends when there're
timeout exception.
If some exception, like 'UnSupportedDataTypeException' throws, there's no
need to retry in other nodes, and we should tell the caller the true error
message, not the outer 'TimeoutExecption'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
