HeimingZ commented on a change in pull request #5320:
URL: https://github.com/apache/iotdb/pull/5320#discussion_r839347700
##########
File path:
server/src/main/java/org/apache/iotdb/db/qp/physical/PhysicalPlan.java
##########
@@ -226,15 +214,18 @@ protected void serializeImpl(ByteBuffer buffer) {
}
/**
- * Deserialize the plan from the given buffer. This is provided for WAL, and
must be used with
- * serializeToWAL.
+ * Deserialize the plan from the given buffer.
*
* @param buffer
*/
public void deserialize(ByteBuffer buffer) throws IllegalPathException,
IOException {
throw new UnsupportedOperationException(SERIALIZATION_UNIMPLEMENTED);
}
+ protected int getSerializedBytesNum(String value) {
+ return value == null ? Integer.BYTES : Integer.BYTES +
value.getBytes().length;
Review comment:
It's old code, you can see current code in
[ReadWriteIOUtils#sizeToWrite](https://github.com/apache/iotdb/pull/5320/files#diff-20f7ca391a64e16b04261240db9b363820d3c4b5afd43b2779d3b718e54b0fa6R459-R464)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
