HeimingZ commented on a change in pull request #5320:
URL: https://github.com/apache/iotdb/pull/5320#discussion_r839351520
##########
File path: server/src/main/java/org/apache/iotdb/db/wal/node/IWALNode.java
##########
@@ -16,35 +16,25 @@
* specific language governing permissions and limitations
* under the License.
*/
+package org.apache.iotdb.db.wal.node;
-package org.apache.iotdb.db.writelog;
-
-import org.apache.iotdb.db.conf.IoTDBDescriptor;
import org.apache.iotdb.db.engine.flush.FlushListener;
import org.apache.iotdb.db.engine.memtable.IMemTable;
-import org.apache.iotdb.db.engine.storagegroup.TsFileProcessor;
-
-import java.io.IOException;
+import org.apache.iotdb.db.qp.physical.crud.DeletePlan;
+import org.apache.iotdb.db.qp.physical.crud.InsertPlan;
+import org.apache.iotdb.db.wal.utils.listener.WALFlushListener;
-public class WALFlushListener implements FlushListener {
+/** This interface provides uniform interface for writing wal and making
checkpoints. */
+public interface IWALNode extends FlushListener, AutoCloseable {
+ /** Log InsertPlan */
+ WALFlushListener log(int memTableId, InsertPlan insertPlan);
- private TsFileProcessor processor;
+ /** Log DeletePlan */
+ WALFlushListener log(int memTableId, DeletePlan deletePlan);
Review comment:
It's unsuitable to use PhysicalPlan here, because only InsertPlan and
DeletePlan can be serialized into wal module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
