[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #9188: use ByteBuffer.slice() to update the origin buffer if buffer.capacity() >= MaxMessageSize in ThriftCommonsSerDeUtils

Wed, 01 Mar 2023 02:01:11 -0800 


OneSizeFitsQuorum commented on code in PR #9188:
URL: https://github.com/apache/iotdb/pull/9188#discussion_r1121445767


##########
node-commons/src/main/java/org/apache/iotdb/commons/utils/ThriftCommonsSerDeUtils.java:
##########
@@ -43,6 +43,8 @@
 /** Utils for serialize and deserialize all the data struct defined by 
thrift-commons */
 public class ThriftCommonsSerDeUtils {
 
+  private static final long THRIFT_DEFAULT_MAX_MESSAGE_SIZE = 104857600;

Review Comment:
   You could use `TConfiguration.DEFAULT_MAX_MESSAGE_SIZE` directly~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to