[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #9188: use ByteBuffer.slice() to update the origin buffer if buffer.capacity() >= MaxMessageSize in ThriftCommonsSerDeUtils

Wed, 01 Mar 2023 02:04:26 -0800 


OneSizeFitsQuorum commented on code in PR #9188:
URL: https://github.com/apache/iotdb/pull/9188#discussion_r1121451039


##########
node-commons/src/main/java/org/apache/iotdb/commons/utils/ThriftCommonsSerDeUtils.java:
##########
@@ -278,4 +280,13 @@ public static TSchemaNode 
deserializeTSchemaNode(ByteBuffer buffer) {
     }
     return schemaNode;
   }
+
+  private static TByteBuffer generateTByteBuffer(ByteBuffer buffer) throws 
TTransportException {
+    // TByteBuffer uses the default TConfiguration which limits the 
MaxMessageSize
+    // we use ByteBuffer.slice() to update the origin buffer if 
buffer.capacity() >= MaxMessageSize
+    if (buffer.capacity() >= THRIFT_DEFAULT_MAX_MESSAGE_SIZE) {
+      buffer.slice();

Review Comment:
   It looks like this function doesn't do anything?
   <img width="582" alt="image" 
src="https://user-images.githubusercontent.com/32640567/222107424-f2b33317-673b-4502-9612-25d2ef4f4215.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to