HTHou commented on code in PR #10742:
URL: https://github.com/apache/iotdb/pull/10742#discussion_r1281264572


##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/executable/ExecutableManager.java:
##########
@@ -227,6 +228,8 @@ protected void saveToDir(ByteBuffer byteBuffer, String 
destination) throws IOExc
     try {
       Path path = Paths.get(destination);
       Files.deleteIfExists(path);
+      // Ensure the target directory exists.
+      SystemFileFactory.INSTANCE.makeDirIfNecessary(destination);

Review Comment:
   > Ok ... so finally I think I've ironed out all quirks ... however no Idea 
why the integration tests only seldomly seem to pass ... haven't quite detected 
a pattern yet.
   
   The failed integration tests are related to Trigger. And the reason is what 
I mentioned in your previous PR #10709. The Line 232 is unnecessary. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to