HTHou commented on code in PR #10742:
URL: https://github.com/apache/iotdb/pull/10742#discussion_r1283045306
##########
pom.xml:
##########
@@ -1109,88 +1115,116 @@
</plugins>
</build>
<profiles>
- <!-- spotless is too slow, so we put it into a profile to skip it if
needed -->
- <profile>
- <id>spotless</id>
- <activation>
- <!-- activeByDefault does not take effect-->
- <file>
- <exists>.</exists>
- </file>
- </activation>
- <build>
- <plugins>
- <plugin>
- <groupId>com.diffplug.spotless</groupId>
- <artifactId>spotless-maven-plugin</artifactId>
- </plugin>
- </plugins>
- </build>
- </profile>
<!--
A set of profiles defining the different properties needed to
download and run thrift
They are automatically activated depending on the OS you are using.
-->
<profile>
- <id>windows</id>
+ <id>.os-unix</id>
<activation>
<os>
- <family>windows</family>
+ <family>unix</family>
+ <arch>!aarch64</arch>
</os>
</activation>
<properties>
- <os.classifier>windows-x86_64</os.classifier>
-
<thrift.download-url>http://archive.apache.org/dist/thrift/${thrift.version}/thrift-${thrift.version}.exe</thrift.download-url>
-
<thrift.executable>thrift-${thrift.version}-win-x86_64.exe</thrift.executable>
-
<thrift.skip-making-executable>true</thrift.skip-making-executable>
- <thrift.exec-cmd.executable>echo</thrift.exec-cmd.executable>
- <thrift.exec-cmd.args>"Do nothing"</thrift.exec-cmd.args>
+ <os.classifier>linux-x86_64</os.classifier>
+ <cmake.generator>Unix Makefiles</cmake.generator>
+ <thrift.executable>thrift</thrift.executable>
Review Comment:
My suggestion is keeping the current way to get thrift from url by default.
And then adding a profile in pom to provide options for people who want build
thrift on their own machines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
