OneSizeFitsQuorum commented on code in PR #10988:
URL: https://github.com/apache/iotdb/pull/10988#discussion_r1308697148
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/service/ConfigNode.java:
##########
@@ -127,17 +126,17 @@ public void active() {
if (SystemPropertiesUtils.isRestarted()) {
LOGGER.info("{} is in restarting process...",
ConfigNodeConstant.GLOBAL_NAME);
- int configNodeId;
- if (!SystemPropertiesUtils.isSeedConfigNode()) {
- // The non-seed-ConfigNodes should send restart request and be
checked (ip and port) by
- // leader before initConsensusManager
- sendRestartConfigNodeRequest();
- configNodeId = CONF.getConfigNodeId();
- } else {
- configNodeId = SEED_CONFIG_NODE_ID;
- }
+ int configNodeId = CONF.getConfigNodeId();
configManager.initConsensusManager();
+ while (configManager.getConsensusManager().getLeader() == null) {
+ // leader has not been elected yet, wait 1 second
+ LOGGER.info("Leader has not been elected yet, wait for 1 second");
+ try {
+ Thread.sleep(1000);
+ } catch (Exception e) {
Review Comment:
catch InterruptedException
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/service/ConfigNode.java:
##########
@@ -127,17 +126,17 @@ public void active() {
if (SystemPropertiesUtils.isRestarted()) {
LOGGER.info("{} is in restarting process...",
ConfigNodeConstant.GLOBAL_NAME);
- int configNodeId;
- if (!SystemPropertiesUtils.isSeedConfigNode()) {
- // The non-seed-ConfigNodes should send restart request and be
checked (ip and port) by
- // leader before initConsensusManager
- sendRestartConfigNodeRequest();
- configNodeId = CONF.getConfigNodeId();
- } else {
- configNodeId = SEED_CONFIG_NODE_ID;
- }
+ int configNodeId = CONF.getConfigNodeId();
configManager.initConsensusManager();
+ while (configManager.getConsensusManager().getLeader() == null) {
+ // leader has not been elected yet, wait 1 second
+ LOGGER.info("Leader has not been elected yet, wait for 1 second");
+ try {
+ Thread.sleep(1000);
+ } catch (Exception e) {
+ }
Review Comment:
log error and break this while?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
