OneSizeFitsQuorum commented on code in PR #10988:
URL: https://github.com/apache/iotdb/pull/10988#discussion_r1309745084
##########
integration-test/src/test/java/org/apache/iotdb/confignode/it/cluster/IoTDBClusterRestartIT.java:
##########
@@ -70,7 +70,7 @@ public void setUp() throws Exception {
.setDataReplicationFactor(testReplicationFactor);
// Init 2C2D cluster environment
Review Comment:
remove this line
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/conf/SystemPropertiesUtils.java:
##########
@@ -401,7 +401,7 @@ private static synchronized Properties
getSystemProperties() throws IOException
private static synchronized void storeSystemProperties(Properties
systemProperties)
throws IOException {
try (FileOutputStream fileOutputStream = new
FileOutputStream(systemPropertiesFile)) {
- systemProperties.store(fileOutputStream, "");
+ systemProperties.store(fileOutputStream, " DO NOT MODIFY THIS FILE !!!");
Review Comment:
"THIS FILE IS AUTOMATICALLY GENERATED. PLEASE DO NOT MODIFY THIS FILE !!!"
##########
integration-test/src/test/java/org/apache/iotdb/confignode/it/cluster/IoTDBClusterRestartIT.java:
##########
@@ -50,15 +51,14 @@
@RunWith(IoTDBTestRunner.class)
@Category({ClusterIT.class})
public class IoTDBClusterRestartIT {
+ private static final Logger logger = IoTDBTestLogger.logger;
private static final String ratisConsensusProtocolClass =
"org.apache.iotdb.consensus.ratis.RatisConsensus";
- private static final int testConfigNodeNum = 2;
- private static final int testDataNodeNum = 2;
+
private static final int testReplicationFactor = 2;
- @Before
- public void setUp() throws Exception {
+ public void setUp(int configNodeNum, int dataNodeNum) {
Review Comment:
How about just use 3c2d?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
