SpriCoder commented on code in PR #11378:
URL: https://github.com/apache/iotdb/pull/11378#discussion_r1372066693
##########
iotdb-core/metrics/core/src/main/resources/META-INF/services/org.apache.iotdb.metrics.AbstractMetricManager:
##########
@@ -15,4 +15,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-org.apache.iotdb.metrics.micrometer.MicrometerMetricManager
Review Comment:
Maybe there is no need to use SPI if we choose micrometer as implementation
##########
iotdb-core/datanode/src/test/java/org/apache/iotdb/db/metric/MetricServiceTest.java:
##########
@@ -55,30 +50,31 @@ public class MetricServiceTest {
MetricConfigDescriptor.getInstance().getMetricConfig();
private static AbstractMetricService metricService = new
DoNothingMetricService();
- @Test
- public void testMetricService() {
- for (MetricFrameType type : MetricFrameType.values()) {
- // init metric service
- metricConfig.setMetricFrameType(type);
- metricConfig.setMetricLevel(MetricLevel.IMPORTANT);
- metricService = new DoNothingMetricService();
- metricService.startService();
-
- // test metric service
-
assertTrue(metricService.getMetricManager().isEnableMetricInGivenLevel(MetricLevel.CORE));
- assertTrue(
-
metricService.getMetricManager().isEnableMetricInGivenLevel(MetricLevel.IMPORTANT));
-
assertFalse(metricService.getMetricManager().isEnableMetricInGivenLevel(MetricLevel.NORMAL));
-
assertFalse(metricService.getMetricManager().isEnableMetricInGivenLevel(MetricLevel.ALL));
-
- testNormalSituation();
-
- testOtherSituation();
-
- // stop metric module
- metricService.stopService();
- }
- }
+ // @Test
+ // public void testMetricService() {
Review Comment:
+1, maybe we should leave the test of micrometer implement
##########
iotdb-core/metrics/pom.xml:
##########
@@ -31,8 +31,8 @@
<name>IoTDB: Core: Metrics</name>
<description>Metrics interfaces for IoTDB</description>
<modules>
+ <module>core</module>
<module>interface</module>
- <module>micrometer-metrics</module>
<module>dropwizard-metrics</module>
Review Comment:
+1, and maybe there is no need to split core and micrometer. What's your
opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
