DanielWang2035 commented on code in PR #11489:
URL: https://github.com/apache/iotdb/pull/11489#discussion_r1400231497
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/async/IoTDBThriftAsyncConnector.java:
##########
@@ -176,13 +171,15 @@ public void transfer(TabletInsertionEvent
tabletInsertionEvent) throws Exception
return;
}
+ final long commitId = ((EnrichedEvent) tabletInsertionEvent).getCommitId();
+
if (isTabletBatchModeEnabled) {
- final long requestCommitId = commitIdGenerator.incrementAndGet();
- if (tabletBatchBuilder.onEvent(tabletInsertionEvent, requestCommitId)) {
+ if (tabletBatchBuilder.onEvent(tabletInsertionEvent)) {
final PipeTransferTabletBatchEventHandler
pipeTransferTabletBatchEventHandler =
new PipeTransferTabletBatchEventHandler(tabletBatchBuilder, this);
- transfer(requestCommitId, pipeTransferTabletBatchEventHandler);
+ transfer(commitId, pipeTransferTabletBatchEventHandler);
Review Comment:
I think this may be inconvenient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
