DanielWang2035 commented on code in PR #11489: URL: https://github.com/apache/iotdb/pull/11489#discussion_r1400377664
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/commit/PipeEventCommitManager.java: ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.pipe.commit; + +import org.apache.iotdb.commons.pipe.plugin.builtin.BuiltinPipePlugin; +import org.apache.iotdb.db.pipe.event.EnrichedEvent; +import org.apache.iotdb.db.pipe.event.common.heartbeat.PipeHeartbeatEvent; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Arrays; +import java.util.Collections; +import java.util.HashSet; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; + +public class PipeEventCommitManager { + + private static final Logger LOGGER = LoggerFactory.getLogger(PipeEventCommitManager.class); + + private static final Set<String> COMMITTABLE_CONNECTORS = + Collections.unmodifiableSet( + new HashSet<>( + Arrays.asList( + BuiltinPipePlugin.IOTDB_THRIFT_CONNECTOR.getPipePluginName(), + BuiltinPipePlugin.IOTDB_THRIFT_SYNC_CONNECTOR.getPipePluginName(), + BuiltinPipePlugin.IOTDB_THRIFT_ASYNC_CONNECTOR.getPipePluginName(), + BuiltinPipePlugin.IOTDB_LEGACY_PIPE_CONNECTOR.getPipePluginName(), + BuiltinPipePlugin.WRITE_BACK_CONNECTOR.getPipePluginName(), + BuiltinPipePlugin.IOTDB_THRIFT_SINK.getPipePluginName(), + BuiltinPipePlugin.IOTDB_THRIFT_SYNC_SINK.getPipePluginName(), + BuiltinPipePlugin.IOTDB_THRIFT_ASYNC_SINK.getPipePluginName(), + BuiltinPipePlugin.IOTDB_LEGACY_PIPE_SINK.getPipePluginName(), + BuiltinPipePlugin.WRITE_BACK_SINK.getPipePluginName()))); + + // key: pipeName_dataRegionId + private final Map<String, PipeEventCommitter> eventCommitterMap = new ConcurrentHashMap<>(); + + public void register(String pipeName, int dataRegionId, String pipePluginName) { + if (pipeName == null || !COMMITTABLE_CONNECTORS.contains(pipePluginName)) { + return; + } + + final String committerKey = generateCommitterKey(pipeName, dataRegionId); + if (eventCommitterMap.containsKey(committerKey)) { + LOGGER.warn("Pipe with same name is already registered, overwriting: {}", committerKey); + } + eventCommitterMap.put(committerKey, new PipeEventCommitter()); + LOGGER.info("Pipe committer registered for pipe: {}", committerKey); Review Comment: fixed ########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/commit/PipeEventCommitManager.java: ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.pipe.commit; + +import org.apache.iotdb.commons.pipe.plugin.builtin.BuiltinPipePlugin; +import org.apache.iotdb.db.pipe.event.EnrichedEvent; +import org.apache.iotdb.db.pipe.event.common.heartbeat.PipeHeartbeatEvent; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Arrays; +import java.util.Collections; +import java.util.HashSet; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; + +public class PipeEventCommitManager { + + private static final Logger LOGGER = LoggerFactory.getLogger(PipeEventCommitManager.class); + + private static final Set<String> COMMITTABLE_CONNECTORS = + Collections.unmodifiableSet( + new HashSet<>( + Arrays.asList( + BuiltinPipePlugin.IOTDB_THRIFT_CONNECTOR.getPipePluginName(), + BuiltinPipePlugin.IOTDB_THRIFT_SYNC_CONNECTOR.getPipePluginName(), + BuiltinPipePlugin.IOTDB_THRIFT_ASYNC_CONNECTOR.getPipePluginName(), + BuiltinPipePlugin.IOTDB_LEGACY_PIPE_CONNECTOR.getPipePluginName(), + BuiltinPipePlugin.WRITE_BACK_CONNECTOR.getPipePluginName(), + BuiltinPipePlugin.IOTDB_THRIFT_SINK.getPipePluginName(), + BuiltinPipePlugin.IOTDB_THRIFT_SYNC_SINK.getPipePluginName(), + BuiltinPipePlugin.IOTDB_THRIFT_ASYNC_SINK.getPipePluginName(), + BuiltinPipePlugin.IOTDB_LEGACY_PIPE_SINK.getPipePluginName(), + BuiltinPipePlugin.WRITE_BACK_SINK.getPipePluginName()))); + + // key: pipeName_dataRegionId + private final Map<String, PipeEventCommitter> eventCommitterMap = new ConcurrentHashMap<>(); + + public void register(String pipeName, int dataRegionId, String pipePluginName) { + if (pipeName == null || !COMMITTABLE_CONNECTORS.contains(pipePluginName)) { + return; + } + + final String committerKey = generateCommitterKey(pipeName, dataRegionId); + if (eventCommitterMap.containsKey(committerKey)) { + LOGGER.warn("Pipe with same name is already registered, overwriting: {}", committerKey); + } + eventCommitterMap.put(committerKey, new PipeEventCommitter()); + LOGGER.info("Pipe committer registered for pipe: {}", committerKey); + } + + public void deregister(String pipeName, int dataRegionId) { + final String committerKey = generateCommitterKey(pipeName, dataRegionId); + eventCommitterMap.remove(committerKey); + LOGGER.info("Pipe committer deregistered for pipe: {}", committerKey); Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
