Cpaulyz commented on code in PR #11681:
URL: https://github.com/apache/iotdb/pull/11681#discussion_r1423699230
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/common/header/ColumnHeaderConstant.java:
##########
@@ -49,6 +49,8 @@ private ColumnHeaderConstant() {
public static final String DEADBAND = "Deadband";
public static final String DEADBAND_PARAMETERS = "DeadbandParameters";
public static final String IS_ALIGNED = "IsAligned";
+ public static final String Template = "Template";
Review Comment:
Keep the code style consistent with the original code.
```suggestion
public static final String TEMPLATE = "Template";
```
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/filter/SchemaFilterFactory.java:
##########
@@ -44,6 +45,10 @@ public static SchemaFilter createViewTypeFilter(ViewType
viewType) {
return new ViewTypeFilter(viewType);
}
+ public static SchemaFilter createTemplateIdFilter(String templateName,
boolean isEqual) {
Review Comment:
Please let the name of the method express the exact meaning.
```suggestion
public static SchemaFilter createTemplateNameFilter(String templateName,
boolean isEqual) {
```
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/schema/source/DeviceSchemaSource.java:
##########
@@ -96,15 +97,28 @@ public void transformToTsBlockColumns(
builder
.getColumnBuilder(0)
.writeBinary(new Binary(device.getFullPath(),
TSFileConfig.STRING_CHARSET));
+
+ String TemplateName = "null";
Review Comment:
Do not use MAGIC NUMBER.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
